Conversation
|
@blueorangutan package |
|
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2312 |
|
@blueorangutan package |
|
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
| -- Fix OS category for Guest OS 'Other PV Virtio-SCSI (64-bit)' | ||
| UPDATE `cloud`.`guest_os` SET category_id = 7 WHERE id = 275 AND display_name = 'Other PV Virtio-SCSI (64-bit)'; | ||
|
|
||
| ALTER TABLE `cloud`.`user_vm` ADD COLUMN `user_vm_type` varchar(255) DEFAULT "UserVM" COMMENT 'Defines the type of UserVM'; |
There was a problem hiding this comment.
@Pearl1594 is this not redundant of Type column in vm_instance table? This type column already used to persist different system VMs (ConsoleProxy, SecondaryStorageVm, DomainRouter), may be you can use this for different user VMs as well.
There was a problem hiding this comment.
Intention of adding a user vm type - as a sub-type of VMInstance type - User is to basically reduce any regression - changing User to other type to accommodate CKS / K8s nodes would possibly require a lot more changes
There was a problem hiding this comment.
Ok @Pearl1594 I think it is better to use single source for defining the instance type.
| @Column(name = "update_parameters", updatable = true) | ||
| protected boolean updateParameters = true; | ||
|
|
||
| @Column(name = "user_vm_type", updatable = true) |
There was a problem hiding this comment.
can use "type" from VMInstanceVO instead?
|
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2313 |
| List<DatadiskTO> templateAsIsDisks = null; | ||
| String configurationId = null; | ||
| if (template.isDeployAsIs()) { | ||
| if (template.isDeployAsIs() && vm.getType() != VirtualMachine.Type.SecondaryStorageVm) { |
There was a problem hiding this comment.
please note there is already a specific PR #4437 with this change
There was a problem hiding this comment.
This was added to verify the fix @sureshanaparti
|
|
||
| static final int MAX_USER_DATA_LENGTH_BYTES = 2048; | ||
|
|
||
| public static enum UserVmType { |
There was a problem hiding this comment.
@Pearl1594 there is a common enum "VirtualMachine.Type" where all the VM types are defined, can use the same?
|
@blueorangutan package |
|
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2316 |
5 participants
Description
With CoreOS having reached End of life, support has been provided CKS to consume systemVM template to deploy kubernetes clusters
Types of changes